[libcamera-devel] [PATCH 04/13] ipa: ipu3: awb: Change minimal green threshold value

[Kieran Bingham]

Quoting Jean-Michel Hautbois (2021-10-13 16:41:16)
> When the zones are used for the grey world algorithm, we need a minimal
> number of zones to make it relevant, and we want the green values to be
> at least 32 today (with a maximum of 255).
> 
> This value is a bit high, as we now are correcting the black levels, and
> a sudden change of colors can be visible for the end user when the gains
> are applied.
> 
> Lower the value to 16.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>  src/ipa/ipu3/algorithms/awb.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
> index 30693923..b18874a3 100644
> --- a/src/ipa/ipu3/algorithms/awb.cpp
> +++ b/src/ipa/ipu3/algorithms/awb.cpp
> @@ -17,7 +17,7 @@ namespace ipa::ipu3::algorithms {
>  
>  LOG_DEFINE_CATEGORY(IPU3Awb)
>  


Do you document the meaning of this constant, and what it is used for /
effects of changing it in the later documentation series?

If not, could you add something please?

(Either in this patch, or later)


Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> -static constexpr uint32_t kMinGreenLevelInZone = 32;
> +static constexpr uint32_t kMinGreenLevelInZone = 16;
>  
>  /**
>   * \struct Accumulator
> -- 
> 2.30.2
>