[libcamera-devel] [PATCH v3 0/2] Camera Control Validator

[paul.elder at ideasonboard.com]

Hi Kieran,

On Wed, Oct 20, 2021 at 02:33:51PM +0100, Kieran Bingham wrote:
> These patches were part of an earlier series, which was partially
> merged.
> 
> As part of cleaning up the request prior to making it use the D-Pointer
> implementation, clean up the todo and use a CameraControlValidator
> provided by the Camera instead of creating a new one for each request.

Looks good to me.

For both,
Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> 
> 
> Kieran Bingham (2):
>   libcamera: camera: Create a CameraControlValidator
>   libcamera: request: Use external CameraControlValidator
> 
>  include/libcamera/internal/camera.h |  6 ++++++
>  include/libcamera/request.h         |  1 -
>  src/libcamera/camera.cpp            |  7 +++++++
>  src/libcamera/request.cpp           | 10 +++-------
>  4 files changed, 16 insertions(+), 8 deletions(-)
> 
> -- 
> 2.30.2
>