[libcamera-devel] [PATCH v6 1/7] android: camera_stream: Replace post-processor nullptr check

Umang Jain umang.jain at ideasonboard.com
Sat Oct 23 12:32:56 CEST 2021


Instead of checking postProcessor for nullptr, replace this
check with an assertion that checks if the camera stream's
type is not Type::Direct. Since it makes no sense to call
CameraStream::process() on a Type::Direct camera stream.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 src/android/camera_stream.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
index f44a2717..ca25c4db 100644
--- a/src/android/camera_stream.cpp
+++ b/src/android/camera_stream.cpp
@@ -163,8 +163,7 @@ int CameraStream::process(const FrameBuffer &source,
 		dest.fence = -1;
 	}
 
-	if (!postProcessor_)
-		return 0;
+	ASSERT(type_ != Type::Direct);
 
 	/*
 	 * \todo Buffer mapping and processing should be moved to a
-- 
2.31.1



More information about the libcamera-devel mailing list