[libcamera-devel] [PATCH v6 2/7] android: post_processor_jpeg: Replace encoder_ nullptr check

Umang Jain umang.jain at ideasonboard.com
Sat Oct 23 12:32:57 CEST 2021


Instead of simply returning if encoder_ is nullptr, fail hard
via an assertion. It is quite unlikely that encoder_ will be
nullptr in PostProcessorJpeg::process() so, be loud about
the failure.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 src/android/jpeg/post_processor_jpeg.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp
index 699576ef..49483836 100644
--- a/src/android/jpeg/post_processor_jpeg.cpp
+++ b/src/android/jpeg/post_processor_jpeg.cpp
@@ -102,9 +102,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,
 			       CameraBuffer *destination,
 			       Camera3RequestDescriptor *request)
 {
-	if (!encoder_)
-		return 0;
-
+	ASSERT(encoder_);
 	ASSERT(destination->numPlanes() == 1);
 
 	const CameraMetadata &requestMetadata = request->settings_;
-- 
2.31.1



More information about the libcamera-devel mailing list