[libcamera-devel] [PATCH v3 04/19] ipa: ipu3: Explicitly use the statistics parameter

[Kieran Bingham]

Quoting Jean-Michel Hautbois (2021-10-22 16:12:03)
> The stats pointer is marked as [[maybe_unused]]. This is a leftover from
> a previous commit which was here to keep the compatibility while
> transitioning to the new iterative algorithms.
> 
> Remove this attribute to make it explicit that stats are really used to
> feed the algorithms.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index c5461d8e..cd27872b 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -715,7 +715,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)
>   */
>  void IPAIPU3::parseStatistics(unsigned int frame,
>                               [[maybe_unused]] int64_t frameTimestamp,
> -                             [[maybe_unused]] const ipu3_uapi_stats_3a *stats)
> +                             const ipu3_uapi_stats_3a *stats)
>  {
>         ControlList ctrls(controls::controls);
>  
> -- 
> 2.32.0
>