[libcamera-devel] [PATCH v3 14/19] ipa: ipu3: algorithms: awb: Privatize internal structures

[Laurent Pinchart]

Hi Jean-Michel and Kieran,

Thank you for the patch.

On Fri, Oct 22, 2021 at 05:12:13PM +0200, Jean-Michel Hautbois wrote:
> From: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> The struct RGB and struct AwbStatus are used only by the internal
> implementation of the AWB algorithm module.
> 
> Move them into the private class declaration.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/ipu3/algorithms/awb.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h
> index 0c81e39e..b90782c1 100644
> --- a/src/ipa/ipu3/algorithms/awb.h
> +++ b/src/ipa/ipu3/algorithms/awb.h
> @@ -42,6 +42,7 @@ public:
>  	void prepare(IPAContext &context, ipu3_uapi_params *params) override;
>  	void process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;
>  
> +private:
>  	/* \todo Make these structs available to all the ISPs ? */
>  	struct RGB {
>  		RGB(double _R = 0, double _G = 0, double _B = 0)

-- 
Regards,

Laurent Pinchart