[libcamera-devel] [PATCH v3 18/19] ipa: ipu3: Implement an empty stop() function

[Laurent Pinchart]

Hi Jean-Michel,

Thank you for the patch.

On Fri, Oct 22, 2021 at 05:12:17PM +0200, Jean-Michel Hautbois wrote:
> While the stop() method does not currently perform any action, it forms

s/method/function/

> part of the IPA interface and is a public function in the class.
> 
> Promote it to a full (but basic) function implementation and begin the
> documentation accordingly so that there is an appropriate stub to
> perform stop operations if they come up.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index 065febf8..ea54413a 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -131,7 +131,7 @@ public:
>  		 ControlInfoMap *ipaControls) override;
>  
>  	int start() override;
> -	void stop() override {}
> +	void stop() override;
>  
>  	int configure(const IPAConfigInfo &configInfo,
>  		      ControlInfoMap *ipaControls) override;
> @@ -319,6 +319,13 @@ int IPAIPU3::start()
>  	return 0;
>  }
>  
> +/**
> + * \brief Ensure that all processing has completed.

s/completed./completed/

> + */
> +void IPAIPU3::stop()
> +{
> +}
> +
>  /**
>   * \brief Calculate a grid for the AWB statistics
>   *

-- 
Regards,

Laurent Pinchart