[libcamera-devel] [PATCH v2 0/7] The Great AE Changes

[Kieran Bingham]

Quoting Paul Elder (2021-10-01 11:33:18)
> This patch series aims to solve all our AE problems.
> 
> The most important patches are 1/7, 6/7, and 7/7.
> 
> 1/7 defines the new AE controls, and replaces the old ones. This will
> not compile without 2/7 to 5/7. 1/7 did not have any reviews so I'm
> putting it in this series.

Ah, ok - so you know about the breakage ;-)

> 6/7 plumbs the AE controls through the HAL layer. It is fairly large and
> complex.
> 
> 7/7 plumbs the sensitivity-related controls, which are also related to
> the AE controls, which is why it is included in this series. It also did
> not have any reviews, so it's being grouped with this series.
> 
> These have yet to be tested against CTS, but the theory should be
> correct.

I can run an integration test on a branch if you like.

> Paul Elder (7):
>   controls: Reorganize the AE-related controls
>   libcamera: pipeline: uvcvideo: Support the new AE controls
>   libcamera: pipeline: raspberrypi: Support the new AE controls
>   test: ipa_data_serializer: Remove controls::AeEnable
>   libcamera: pipeline: rkisp1: Support the new AE controls
>   android: Plumb all AE-related controls
>   android: Plumb all sensitivity-related controls
> 
>  include/libcamera/ipa/raspberrypi.h           |   3 +-
>  src/android/camera_capabilities.cpp           | 124 ++++++++--
>  src/android/camera_capabilities.h             |   3 +-
>  src/android/camera_device.cpp                 | 174 +++++++++++++-
>  src/android/camera_device.h                   |  17 ++
>  src/android/camera_hal_config.cpp             |  10 +-
>  src/android/camera_hal_config.h               |   1 +
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    |  18 +-
>  src/ipa/raspberrypi/controller/rpi/agc.hpp    |   5 +
>  src/ipa/raspberrypi/raspberrypi.cpp           |  42 +++-
>  src/ipa/rkisp1/rkisp1.cpp                     |  18 +-
>  src/libcamera/control_ids.yaml                | 215 ++++++++++++------
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   4 +-
>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  36 ++-
>  .../ipa_data_serializer_test.cpp              |   1 -
>  15 files changed, 559 insertions(+), 112 deletions(-)
> 
> -- 
> 2.27.0
>