[libcamera-devel] [PATCH 11/16] android: capabilities: Print output stream list

[paul.elder at ideasonboard.com]

Hi Jacopo,

On Fri, Aug 27, 2021 at 02:07:52PM +0200, Jacopo Mondi wrote:
> Add a debug statement to print out the list of collected output stream

s/stream/streams/

> and their characteristics.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/android/camera_capabilities.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp
> index c1ce63018aa8..484242d0ad81 100644
> --- a/src/android/camera_capabilities.cpp
> +++ b/src/android/camera_capabilities.cpp
> @@ -1277,6 +1277,13 @@ int CameraCapabilities::initializeStaticMetadata()
>  		availableStreamConfigurations.push_back(entry.resolution.height);
>  		availableStreamConfigurations.push_back(
>  			ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);
> +
> +		LOG(HAL, Debug)
> +			<< "Output Stream:" << utils::hex(entry.androidFormat)
> +			<< "(" << entry.resolution.width << "x"

Would s/:/: / and s/(/ (/ look better?


Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> +			<< entry.resolution.height << ")["
> +			<< entry.minFrameDurationNsec << "]"
> +			<< "@" << fps;
>  	}
>  	staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,
>  				  availableStreamConfigurations);
> -- 
> 2.32.0
>