[libcamera-devel] [PATCH 0/6] libcamera: control serializer fixes

Jacopo Mondi jacopo at jmondi.org
Wed Sep 1 16:37:54 CEST 2021


This series has started from investigating an error triggered by running
consecutive capture sessions with the IPU3 IPA module running in isolation.

>From there a few more fixes/improvements have lead me to be capable to running
CTS with isolated IPA with a single failure (the flaky recording tests).

Patch 1 is a small cleanup of the IPU3 IPA interface.
Patches 2, 3 and 4 fix issues in the control serializer, most of them went not
noticed as the IPA is seldom run isolated for the moment.

Patch 5 is a small drive-by change

Patch 6 fixes a log standing debt, and add the ability to ser/deser the
ControlInfo::def field.

Thanks
   j

Jacopo Mondi (6):
  libcamera: ipu3: Drop entityControls map
  ipa: proxy_worker: Reset ControlSerializer on worker
  libcamera: control_serializer: Keep handles in sync
  libcamera: control_serializer: Use the right idmap
  libcamera: controls: Rationalize idMap() function
  libcamera: control_serializer: Serialize info::def()

 include/libcamera/controls.h                  |  3 +-
 include/libcamera/ipa/ipu3.mojom              |  2 +-
 src/ipa/ipu3/ipu3.cpp                         |  4 +-
 src/libcamera/camera_sensor.cpp               |  2 +-
 src/libcamera/control_serializer.cpp          | 60 +++++++++++++++----
 src/libcamera/controls.cpp                    | 12 +++-
 src/libcamera/delayed_controls.cpp            |  4 +-
 src/libcamera/ipa_controls.cpp                | 14 +++--
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  2 +-
 .../module_ipa_proxy_worker.cpp.tmpl          |  4 ++
 10 files changed, 79 insertions(+), 28 deletions(-)

--
2.32.0



More information about the libcamera-devel mailing list