[libcamera-devel] [PATCH v1 2/5] qcam: format_converter: Add configurable stride support

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Sep 7 01:20:50 CEST 2021


On 07/09/2021 00:04, Laurent Pinchart wrote:
> Make the stride configurable to support convertion of images with
> padding at the end of lines.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/qcam/format_converter.cpp | 19 ++++++++++---------
>  src/qcam/format_converter.h   |  4 +++-
>  src/qcam/viewfinder_qt.cpp    |  5 ++---
>  3 files changed, 15 insertions(+), 13 deletions(-)
> 
> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp
> index 673ad33e141d..7f7ddb2dc77b 100644
> --- a/src/qcam/format_converter.cpp
> +++ b/src/qcam/format_converter.cpp
> @@ -30,7 +30,7 @@
>  #endif
>  
>  int FormatConverter::configure(const libcamera::PixelFormat &format,
> -			       const QSize &size)
> +			       const QSize &size, unsigned int stride)
>  {
>  	switch (format) {
>  	case libcamera::formats::NV12:
> @@ -121,22 +121,22 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,
>  		break;
>  
>  	case libcamera::formats::VYUY:
> -		formatFamily_ = YUV;
> +		formatFamily_ = YUVPacked;

Given the title of the next patch, I think these may have got squashed
into the wrong commit?

--
Kieran


More information about the libcamera-devel mailing list