[libcamera-devel] [SimpleCam PATCH] simple-cam: Use new metadata API

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thu, Sep 09, 2021 at 01:14:47PM +0100, Kieran Bingham wrote:
> In libcamera commit 32635054bc76 ("libcamera: framebuffer: Prevent
> modifying the number of metadata planes"), the planes are returned as a
> const span rather than a vector from the metadata.
> 
> This provides better protection on the underlying structures, but was a
> break in the API.
> 
> Update simple-cam to use the new API.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  simple-cam.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/simple-cam.cpp b/simple-cam.cpp
> index a8ac3c83ccb5..95e472b4377a 100644
> --- a/simple-cam.cpp
> +++ b/simple-cam.cpp
> @@ -58,10 +58,10 @@ static void processRequest(Request *request)
>  			  << " bytesused: ";
>  
>  		unsigned int nplane = 0;
> -		for (const FrameMetadata::Plane &plane : metadata.planes)
> +		for (const FrameMetadata::Plane &plane : metadata.planes())
>  		{
>  			std::cout << plane.bytesused;
> -			if (++nplane < metadata.planes.size())
> +			if (++nplane < metadata.planes().size())
>  				std::cout << "/";

To quote one of your previous reviews, this can be confusing for
applications ;-)

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  		}
>  

-- 
Regards,

Laurent Pinchart