[libcamera-devel] New Defects reported by Coverity Scan for libcamera

[Kieran Bingham]

On 09/09/2021 15:07, Vedant Paranjape wrote:
> Hey, I think you have the wrong patch. I sent a v5 just some hours back,
> it fixed all the issues shown here.

Unfortunately Coverity only scans the mainline integrated commits, so
it's picked this up from :

  "test: gstreamer: Factor out code into a base class"

If it's fixed in the incoming patches, then there is no issue.

Thanks.

Kieran


> 
> Regards,
> /*Vedant Paranjape*/
> 
> On Thu, Sep 9, 2021 at 7:35 PM Kieran Bingham
> <kieran.bingham at ideasonboard.com
> <mailto:kieran.bingham at ideasonboard.com>> wrote:
> 
>     Hi Vedant,
> 
>     These reports have been generated by Coverity.
>     They may be false positives, but just so you're aware in case they are
>     an issue.
> 
>     --
>     Kieran
> 
> 
> 
>     -------- Forwarded Message --------
>     Subject: New Defects reported by Coverity Scan for libcamera
>     Date: Thu, 09 Sep 2021 14:00:44 +0000 (UTC)
>     From: scan-admin at coverity.com <mailto:scan-admin at coverity.com>
>     To: kieran.bingham at ideasonboard.com
>     <mailto:kieran.bingham at ideasonboard.com>
> 
>     Hi,
> 
>     Please find the latest report on new defect(s) introduced to libcamera
>     found with Coverity Scan.
> 
>     2 new defect(s) introduced to libcamera found with Coverity Scan.
> 
> 
>     New defect(s) Reported-by: Coverity Scan
>     Showing 2 of 2 defect(s)
> 
> 
>     ** CID 356329:    (UNINIT_CTOR)
>     /home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:
>     47 in GstreamerTest::GstreamerTest()()
>     /home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:
>     68 in GstreamerTest::GstreamerTest()()
> 
> 
>     ________________________________________________________________________________________________________
>     *** CID 356329:    (UNINIT_CTOR)
>     /home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:
>     47 in GstreamerTest::GstreamerTest()()
>     41      g_autoptr(GError) errInit = NULL;
>     42      if (!gst_init_check(nullptr, nullptr, &errInit)) {
>     43              g_printerr("Could not initialize GStreamer: %s\n",
>     44                         errInit ? errInit->message : "unknown
>     error");
>     45     46               status_ = TestFail;
>     >>>     CID 356329:    (UNINIT_CTOR)
>     >>>     Non-static class member "libcameraSrc_" is not initialized
>     in this constructor nor in any functions that it calls.
>     47              return;
>     48      }
>     49     50       /*
>     51      * Remove the system libcamera plugin, if any, and add the
>     52      * plugin from the build directory.
>     /home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:
>     68 in GstreamerTest::GstreamerTest()()
>     62     63               status_ = TestFail;
>     64              return;
>     65      }
>     66     67       status_ = TestPass;
>     >>>     CID 356329:    (UNINIT_CTOR)
>     >>>     Non-static class member "libcameraSrc_" is not initialized
>     in this constructor nor in any functions that it calls.
>     68     }
>     69     70     GstreamerTest::~GstreamerTest()
>     71     {
>     72      if (libcameraSrc_ &&
>     73          !gst_object_has_as_ancestor(GST_OBJECT(libcameraSrc_),
> 
>     ** CID 356328:  Uninitialized members  (UNINIT_CTOR)
>     /home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_single_stream_test.cpp:
>     28 in GstreamerSingleStreamTest::GstreamerSingleStreamTest()()
> 
> 
>     ________________________________________________________________________________________________________
>     *** CID 356328:  Uninitialized members  (UNINIT_CTOR)
>     /home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_single_stream_test.cpp:
>     28 in GstreamerSingleStreamTest::GstreamerSingleStreamTest()()
>     22     class GstreamerSingleStreamTest : public GstreamerTest,
>     public Test
>     23     {
>     24     public:
>     25      GstreamerSingleStreamTest()
>     26              : GstreamerTest()
>     27      {
>     >>>     CID 356328:  Uninitialized members  (UNINIT_CTOR)
>     >>>     Non-static class member "sink0_" is not initialized in this
>     constructor nor in any functions that it calls.
>     28      }
>     29     30     protected:
>     31      int init() override
>     32      {
>     33              if (status_ != TestPass)
> 
> 
>     ________________________________________________________________________________________________________
>     To view the defects in Coverity Scan visit,
>     https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrU0jHZztxHSfchEdEv-2BUERKUFDFlzchxJzxDB2S7OB7lr-2Fth-2F9ZTRF1ITl33bQQto-3DRAq-_qXXIY1fr7HINeQlTFVXABgVX8iKf8Pc2W6xJCOtsiCw64f2YdDCRdgu4-2FkWCuqEXXWChBofooTa0y8KFKOtgnQjde4dBU-2FZgvswyAI5XO0ekKbl9nJU6QKX8C2y6l1P7xdneHu7FTOGRCCAOgFpo9CzI1NUv0wR5mDIWD0v-2BUaNkvZl7QKJqhKIko14Culzsq4C22fUP2mTGLY6ahhRTdrC-2F-2BpJjGS7x-2F0NNU9aMIj8-3D
>     <https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrU0jHZztxHSfchEdEv-2BUERKUFDFlzchxJzxDB2S7OB7lr-2Fth-2F9ZTRF1ITl33bQQto-3DRAq-_qXXIY1fr7HINeQlTFVXABgVX8iKf8Pc2W6xJCOtsiCw64f2YdDCRdgu4-2FkWCuqEXXWChBofooTa0y8KFKOtgnQjde4dBU-2FZgvswyAI5XO0ekKbl9nJU6QKX8C2y6l1P7xdneHu7FTOGRCCAOgFpo9CzI1NUv0wR5mDIWD0v-2BUaNkvZl7QKJqhKIko14Culzsq4C22fUP2mTGLY6ahhRTdrC-2F-2BpJjGS7x-2F0NNU9aMIj8-3D>
>