[libcamera-devel] [PATCH] README: Fix android dependencies

[Kieran Bingham]

On 09/09/2021 16:07, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote:
>> While the distribution is unspecified, The README.rst gives
>> debian/ubuntu named dependencies for all except the android
>> requirements.
>>
>> Update the android dependencies to match the others, by showing that the
>> -dev package is required.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>> ---
>>  README.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/README.rst b/README.rst
>> index cf81eca42149..6eb25c708180 100644
>> --- a/README.rst
>> +++ b/README.rst
>> @@ -88,7 +88,7 @@ for tracing with lttng: [optional]
>>          liblttng-ust-dev python3-jinja2 lttng-tools
>>  
>>  for android: [optional]
>> -        libexif libjpeg libyaml
>> +        libexif-dev libjpeg-dev libyaml-dev
> 
> I'm curious to know how you'll use the Android camera HAL on a
> Debian-based distribution :-) It's coherent with the rest of the file
> though, so

True ... but I compile test with everything enabled, including Android,
and saw this while trying to dockerise the build so the whole build
environment was specified.

It's mostly the consistency indeed here, as you're right. We wouldn't
normally expect the android HAL to be compiled otherwise.

It even makes me doubt the patch entirely ...

> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
>>  Using GStreamer plugin
>>  ~~~~~~~~~~~~~~~~~~~~~~
>