[libcamera-devel] [PATCH] android: yuv: Remove CameraDevice forward-declare

Hirokazu Honda hiroh at chromium.org
Fri Sep 10 10:26:57 CEST 2021


Hi Umang, thank you for the patch.

On Fri, Sep 10, 2021 at 3:36 PM Jacopo Mondi <jacopo at jmondi.org> wrote:
>
> Hi Umang,
>
> On Thu, Sep 09, 2021 at 08:48:26PM +0530, Umang Jain wrote:
> > YUV post-processor doesn't need any instance reference from CameraDevice
> > class. Remove it.
> >
> > Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
>
> indeed it seems unused!
>
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

-Hiro

> Thanks
>   j
>
> > ---
> >  src/android/yuv/post_processor_yuv.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/src/android/yuv/post_processor_yuv.h b/src/android/yuv/post_processor_yuv.h
> > index f8b1ba23..12f7af07 100644
> > --- a/src/android/yuv/post_processor_yuv.h
> > +++ b/src/android/yuv/post_processor_yuv.h
> > @@ -11,8 +11,6 @@
> >
> >  #include <libcamera/geometry.h>
> >
> > -class CameraDevice;
> > -
> >  class PostProcessorYuv : public PostProcessor
> >  {
> >  public:
> > --
> > 2.31.0
> >


More information about the libcamera-devel mailing list