[libcamera-devel] [PATCH v1 1/2] android: jpeg: Rectify variable naming style.

[Hirokazu Honda]

Hi Umang,

On Fri, Sep 10, 2021 at 7:47 PM Umang Jain <umang.jain at ideasonboard.com> wrote:
>
> Rectify variable renaming style for YPlaneSize, UVPlaneSize.
> libcamera uses camelCase where first letter should be in lower case.
>
> Fixes: e355ca0087cd9("android: jpeg: Split and pass the thumbnail planes to encoder")
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Sorry for capitalized names in my suggestion.

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>
> ---
>  src/android/jpeg/post_processor_jpeg.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp
> index ef2d98cc..f6d47f63 100644
> --- a/src/android/jpeg/post_processor_jpeg.cpp
> +++ b/src/android/jpeg/post_processor_jpeg.cpp
> @@ -82,10 +82,10 @@ void PostProcessorJpeg::generateThumbnail(const FrameBuffer &source,
>                  */
>                 std::vector<Span<uint8_t>> thumbnailPlanes;
>                 const PixelFormatInfo &formatNV12 = PixelFormatInfo::info(formats::NV12);
> -               size_t YPlaneSize = formatNV12.planeSize(targetSize, 0);
> -               size_t UVPlaneSize = formatNV12.planeSize(targetSize, 1);
> -               thumbnailPlanes.push_back({ rawThumbnail.data(), YPlaneSize });
> -               thumbnailPlanes.push_back({ rawThumbnail.data() + YPlaneSize, UVPlaneSize });
> +               size_t yPlaneSize = formatNV12.planeSize(targetSize, 0);
> +               size_t uvPlaneSize = formatNV12.planeSize(targetSize, 1);
> +               thumbnailPlanes.push_back({ rawThumbnail.data(), yPlaneSize });
> +               thumbnailPlanes.push_back({ rawThumbnail.data() + yPlaneSize, uvPlaneSize });
>
>                 int jpeg_size = thumbnailEncoder_.encode(thumbnailPlanes,
>                                                          *thumbnail, {}, quality);
> --
> 2.31.0
>