[libcamera-devel] [PATCH] README: Fix android dependencies

[Laurent Pinchart]

Hi Hiro,

On Fri, Sep 10, 2021 at 05:25:42PM +0900, Hirokazu Honda wrote:
> On Fri, Sep 10, 2021 at 9:41 AM <paul.elder at ideasonboard.com> wrote:
> > On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote:
> > > While the distribution is unspecified, The README.rst gives
> > > debian/ubuntu named dependencies for all except the android
> > > requirements.
> > >
> > > Update the android dependencies to match the others, by showing that the
> > > -dev package is required.
> > >
> > > Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> >
> > Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> 
> I thought the direction was opposite. I would rather drop "-dev" of
> other dependencies.
> A user shall look for proper packages in their platform for dependencies.
> Having "-dev" seems to centralize debian/ubuntu package systems. How
> about other distributions..?

Most of us, and it seems a large part of our users, use Debian-based
distributions (I use Gentoo personally ;-)). I think it would be nice to
list depednencies for other distributions too, if someone wants to
submit a patch. I'm not sure how to best format the data though, we may
need to turn it into a table.

> > > ---
> > >  README.rst | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/README.rst b/README.rst
> > > index cf81eca42149..6eb25c708180 100644
> > > --- a/README.rst
> > > +++ b/README.rst
> > > @@ -88,7 +88,7 @@ for tracing with lttng: [optional]
> > >          liblttng-ust-dev python3-jinja2 lttng-tools
> > >
> > >  for android: [optional]
> > > -        libexif libjpeg libyaml
> > > +        libexif-dev libjpeg-dev libyaml-dev
> > >
> > >  Using GStreamer plugin
> > >  ~~~~~~~~~~~~~~~~~~~~~~

-- 
Regards,

Laurent Pinchart