[libcamera-devel] [PATCH 05/11] ipa: ipu3: Explicitly use the statistics parameter

[Laurent Pinchart]

Hi Jean-Michel,

Thank you for the patch.

On Mon, Sep 13, 2021 at 04:58:04PM +0200, Jean-Michel Hautbois wrote:
> The stats pointer is marked as [[maybe_unused]]. This is a leftover from
> a previous commit which was here to keep the compatibility while
> transitioning to the new iterative algorithms.
> 
> Remove this attribute to make it explicit that stats are really used to
> feed the algorithms.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

I wish there was an [[unused]] attribute that would cause a warning if
the variable is used :-S

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index df64b0f1..5b487dcd 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -597,7 +597,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)
>   */
>  void IPAIPU3::parseStatistics(unsigned int frame,
>  			      [[maybe_unused]] int64_t frameTimestamp,
> -			      [[maybe_unused]] const ipu3_uapi_stats_3a *stats)
> +			      const ipu3_uapi_stats_3a *stats)
>  {
>  	ControlList ctrls(controls::controls);
>  

-- 
Regards,

Laurent Pinchart