[libcamera-devel] [PATCH v8 0/5] Move and improve AWB structures

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Tue Sep 14 18:37:04 CEST 2021


On the path towards a cleaner and more documented IPA for the IPU3, this
series changes the structures used by the AWB algorithm.

- v8 inverts patch 4 and 5 from the previous series, and the final one
  is now the moving of the new stats structure. And the one before is a
  rework to make the namings consistent between all algorithms (which
  leads to a bit more code reworded in AGC).
- v7 changes a bit of naming in the Awb::generateAwbStats function to
  make it even clearer.
- v6 adds a real better documentation in the AWB part (thanks Kieran)
  and properly defines the terms used in the algorithm (cell and zone).
  A new patch appears which is here to make it consistent.
- v5 is a small rewording of the commit messages for 2/4 and 4/4.
- v4 changes the way the structure is used in intel-ipu3.h to avoid any
  change in the buffer size. It should be transparent.

Patch 1/5 moves the AWB structures to be able to use those from the
ipa::ipu3::algorithms namespace (by AGC at least).

Patch 2/5 renames the stats region structure to make it clear it is an
accumulator structure.

Patch 3/5 is improving the Accumulator structure to have the same layout
as the IPAFrameContext::awb structure.

Patch 4/5 is a bit reworked and covers Awb and Agc. Awb is only
renaming, while Agc should have been only that... if it was not badly
written :-). So it has been reworked a bit more.

Patch 5/5 is removing the IPU3AwbCell from libcamera, and uses its
definition directly from the kernel header.

Jean-Michel Hautbois (5):
  ipa: ipu3: Move the AWB stats structures
  ipa: ipu3: Rename IspStatsRegion to Accumulator
  ipa: ipu3: Change Accumulator structure layout
  ipa: ipu3: Make the naming consistent
  ipa: ipu3: Replace ipa::ipu3::algorithms::Ipu3AwbCell

 include/linux/intel-ipu3.h      |  28 +++++++-
 src/ipa/ipu3/algorithms/agc.cpp |  43 +++---------
 src/ipa/ipu3/algorithms/awb.cpp | 120 +++++++++++++++++++++-----------
 src/ipa/ipu3/algorithms/awb.h   |  30 +++-----
 4 files changed, 128 insertions(+), 93 deletions(-)

-- 
2.30.2



More information about the libcamera-devel mailing list