[libcamera-devel] [PATCH] test: serialization: Prevent parallelisation

paul.elder at ideasonboard.com paul.elder at ideasonboard.com
Wed Sep 15 04:59:05 CEST 2021


Hi Kieran,

On Tue, Sep 14, 2021 at 06:51:30PM +0300, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Tue, Sep 14, 2021 at 01:24:52PM +0100, Kieran Bingham wrote:
> > The ipa_data_serializer_test is configured to be able to run in parallel
> > with other tests.
> > 
> > If the test tries to acquire the VIMC sensor B while it is in use, it
> > would require skipping the test.
> > 
> > Instead, inform meson that it can not be run in parallel to ensure that
> > the test is able to obtain the resources it requires for execution.

Oops :p

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> I ran into that issue before and put it in my todo list. Thanks for
> fixing it :-)
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> > ---
> >  test/serialization/meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/test/serialization/meson.build b/test/serialization/meson.build
> > index 5446e4907f33..26e42b150b40 100644
> > --- a/test/serialization/meson.build
> > +++ b/test/serialization/meson.build
> > @@ -12,5 +12,5 @@ foreach t : serialization_tests
> >                       dependencies : libcamera_private,
> >                       link_with : test_libraries,
> >                       include_directories : test_includes_internal)
> > -    test(t[0], exe, suite : 'serialization', is_parallel : true)
> > +    test(t[0], exe, suite : 'serialization', is_parallel : false)
> >  endforeach
> 
> -- 
> Regards,
> 
> Laurent Pinchart


More information about the libcamera-devel mailing list