[libcamera-devel] [PATCH] libcamera: Standardize URLs to git repositories

[Umang Jain]

Hi Laurent,

Thank you for the patch

On 9/22/21 5:38 PM, Laurent Pinchart wrote:
> When the libcamera project was started, we had no public git tree hosted
> on git.libcamera.org. The problem has been addressed a while ago, and
> the git.linuxtv.org repository is now a mirror of the main git tree. The


s/ git.linuxtv.org / git.linuxtv.org/libcamera.git/  maybe? or simply,

s/ git.linuxtv.org / git.linuxtv.org libcamera /

> mirror is useful to benefit from the linuxtv.org automated compile
> tests, but it can also confuse users who don't know where the official
> version is. To try and clarify this, use the git.libcamera.org URL
> consistently through the project.
>
> This doesn't the validatity of the linuxtv.org repository which will


s/doesn't /doesn't void / maybe?

> continue to mirror the libcamera.org repository.
>
> Signed-off-by: Laurent Pinchart<laurent.pinchart at ideasonboard.com>
> ---
>   README.rst                                                | 2 +-
>   package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)


Should references to https://git.linuxtv.org/libcamera* inside 
Documentation/ be replaced as well?

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> diff --git a/README.rst b/README.rst
> index 6eb25c708180..a0cc45978b0b 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -32,7 +32,7 @@ To fetch the sources, build and install:
>   
>   ::
>   
> -  git clonegit://linuxtv.org/libcamera.git
> +  git clonehttps://git.libcamera.org/libcamera/libcamera.git
>     cd libcamera
>     meson build
>     ninja -C build install
> diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> index ca216c0ae909..65619e07d4ae 100644
> --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> @@ -8,7 +8,7 @@ inherit git-r3 meson python-any-r1
>   
>   DESCRIPTION="Camera support library for Linux"
>   HOMEPAGE="http://libcamera.org"
> -EGIT_REPO_URI="git://linuxtv.org/libcamera.git"
> +EGIT_REPO_URI="https://git.libcamera.org/libcamera/libcamera.git"
>   EGIT_BRANCH="master"
>   
>   LICENSE="LGPL-2.1+"
>
> base-commit: a3b1539869ae53a6446a1c31bdade6560f91a46b