[libcamera-devel] [PATCH v2] libcamera: Standardize URLs to git repositories

[Umang Jain]

Hi Laurent,

Thank you for the patch.

On 9/23/21 5:06 PM, Laurent Pinchart wrote:
> When the libcamera project was started, we had no public git tree hosted
> on git.libcamera.org. The problem has been addressed a while ago, and
> the git.linuxtv.org libcamera repository is now a mirror of the main git
> tree. The mirror is useful to benefit from the linuxtv.org automated
> compile tests, but it can also confuse users who don't know where the
> official version is. To try and clarify this, use the git.libcamera.org
> URL consistently through the project.
>
> This doesn't void the validatity of the linuxtv.org repository which
> will continue to mirror the libcamera.org repository.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>


LGTM,

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   Documentation/contributing.rst                        | 11 +++++++----
>   Documentation/guides/application-developer.rst        | 10 +++++-----
>   README.rst                                            |  2 +-
>   .../gentoo/media-libs/libcamera/libcamera-9999.ebuild |  2 +-
>   4 files changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst
> index 6da82bac4f96..b192c3b43153 100644
> --- a/Documentation/contributing.rst
> +++ b/Documentation/contributing.rst
> @@ -30,14 +30,17 @@ Source Code
>   -----------
>   
>   libcamera is in early stages of development, and no releases are available yet.
> -The source code is available from the project's `git tree`_, hosted by `LinuxTV`_.
> +The source code is available from the project's `git tree`_.
>   
>   .. code-block:: shell
>   
> -  $ git clone git://linuxtv.org/libcamera.git
> +  $ git clone https://git.libcamera.org/libcamera/libcamera.git
>   
> -.. _git tree: https://git.linuxtv.org/libcamera.git/
> -.. _LinuxTV: https://linuxtv.org/
> +.. _git tree: https://git.libcamera.org/libcamera/libcamera.git/
> +
> +A mirror is also hosted on `LinuxTV`_.
> +
> +.. _LinuxTV: https://git.linuxtv.org/libcamera.git/
>   
>   Issue Tracker
>   -------------
> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> index 84e522c01c85..ae28c96b5aca 100644
> --- a/Documentation/guides/application-developer.rst
> +++ b/Documentation/guides/application-developer.rst
> @@ -469,7 +469,7 @@ instance. An example of how to write image data to disk is available in the
>   `FileSink class`_ which is a part of the ``cam`` utility application in the
>   libcamera repository.
>   
> -.. _FileSink class: https://git.linuxtv.org/libcamera.git/tree/src/cam/file_sink.cpp
> +.. _FileSink class: https://git.libcamera.org/libcamera/libcamera.git/tree/src/cam/file_sink.cpp
>   
>   With the handling of this request completed, it is possible to re-use the
>   buffers by adding them to a new ``Request`` instance with their matching
> @@ -575,12 +575,12 @@ which is also the official build system of the libcamera library.
>   
>   Make sure both ``meson`` and ``libcamera`` are installed in your system. Please
>   refer to your distribution documentation to install meson and install the most
> -recent version of libcamera from the git repository at `Linux TV`_. You would
> -also need to install the ``pkg-config`` tool to correctly identify the
> -libcamera.so object install location in the system.
> +recent version of libcamera from the `git repository`_. You would also need to
> +install the ``pkg-config`` tool to correctly identify the libcamera.so object
> +install location in the system.
>   
>   .. _Meson build system: https://mesonbuild.com/
> -.. _Linux TV: https://git.linuxtv.org/libcamera.git/
> +.. _git repository: https://git.libcamera.org/libcamera/libcamera.git/
>   
>   Dependencies
>   ~~~~~~~~~~~~
> diff --git a/README.rst b/README.rst
> index 6eb25c708180..a0cc45978b0b 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -32,7 +32,7 @@ To fetch the sources, build and install:
>   
>   ::
>   
> -  git clone git://linuxtv.org/libcamera.git
> +  git clone https://git.libcamera.org/libcamera/libcamera.git
>     cd libcamera
>     meson build
>     ninja -C build install
> diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> index ca216c0ae909..65619e07d4ae 100644
> --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> @@ -8,7 +8,7 @@ inherit git-r3 meson python-any-r1
>   
>   DESCRIPTION="Camera support library for Linux"
>   HOMEPAGE="http://libcamera.org"
> -EGIT_REPO_URI="git://linuxtv.org/libcamera.git"
> +EGIT_REPO_URI="https://git.libcamera.org/libcamera/libcamera.git"
>   EGIT_BRANCH="master"
>   
>   LICENSE="LGPL-2.1+"
>
> base-commit: 2cc4303b172a76ac5b431c4fb4df8a083f7d3fcf