[libcamera-devel] [PATCH] fixup! ipa: ipu3: Change limits and split loops in calculateBdsGrid()

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Thu Sep 23 14:05:24 CEST 2021


Hi JM,

I think you should take this fixup for your v2 ;-).

---
 src/ipa/ipu3/ipu3.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index 06d9bcb8..3868a3a5 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -321,6 +321,7 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)
 		bestLog2.width = shift;
 	}
 
+	minError = std::numeric_limits<uint32_t>::max();
 	for (shift = kMinCellSizeLog2; shift <= kMaxCellSizeLog2; ++shift) {
 		uint32_t height = std::clamp(bdsOutputSize.height >> shift,
 					     kMinCellHeightPerSet,
-- 
2.30.2



More information about the libcamera-devel mailing list