[libcamera-devel] [PATCH] libcamera: camera_manager: Fix utils.h #include location

Umang Jain umang.jain at ideasonboard.com
Sat Sep 25 05:59:53 CEST 2021


Hi Laurent,

On 9/24/21 8:33 PM, Laurent Pinchart wrote:
> The utils.h header #include is separate from the rest of the group for
> no reason. Move it to where it should be.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/libcamera/camera_manager.cpp | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index e7d026ae94c8..43bfa2b72a51 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -12,10 +12,9 @@
>   
>   #include <libcamera/camera.h>
>   
> -#include <libcamera/base/utils.h>
> -
>   #include <libcamera/base/log.h>
>   #include <libcamera/base/thread.h>
> +#include <libcamera/base/utils.h>
>   
>   #include "libcamera/internal/device_enumerator.h"
>   #include "libcamera/internal/ipa_manager.h"
>
> base-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8


More information about the libcamera-devel mailing list