[libcamera-devel] [PATCH 2/2] simple-cam: Use matching type to store stream size

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Sep 26 22:41:58 CEST 2021


Hi Dorota,

Thank you for the patch.

On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:
> From: Dorota Czaplejewicz <dorota.czaplejewicz at puri.sm>

We usually try to have a commit message body, even for simple patches.
This could be

The std::vector::size() function returns a size_t. Use the same type of
the variable that stores the return value to avoid a compiler warning.

I'll let Kieran apply the patches, I'm sure he can update the commit
message with the above text (if you're fine with it).

> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz at puri.sm>
> ---
>  simple-cam.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/simple-cam.cpp b/simple-cam.cpp
> index 350f68be7906..e374e45849dc 100644
> --- a/simple-cam.cpp
> +++ b/simple-cam.cpp
> @@ -299,7 +299,7 @@ int main()
>  			return EXIT_FAILURE;
>  		}
>  
> -		unsigned int allocated = allocator->buffers(cfg.stream()).size();
> +		size_t allocated = allocator->buffers(cfg.stream()).size();
>  		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
>  	}
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list