[libcamera-devel] [PATCH 1/3] Documentation: application-developer: Make global variable static

[paul.elder at ideasonboard.com]

Hi Laurent,

On Mon, Sep 27, 2021 at 12:21:06AM +0300, Laurent Pinchart wrote:
> The global "camera" variable isn't accessed outside of its compilation
> unit. Make it static.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  Documentation/guides/application-developer.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> index ae28c96b5aca..3de13060db08 100644
> --- a/Documentation/guides/application-developer.rst
> +++ b/Documentation/guides/application-developer.rst
> @@ -58,7 +58,7 @@ variable for the camera to support the event call back later:
>  
>  .. code:: cpp
>  
> -   std::shared_ptr<Camera> camera;
> +   static std::shared_ptr<Camera> camera;
>  
>  Create a Camera Manager instance at the beginning of the main function, and then
>  start it. An application must only create a single Camera Manager instance.
> 
> base-commit: 72e8e03719aa552abce7eeee8a6e4a9b8eb8443e
> --