[libcamera-devel] [PATCH] fixup! ipa: ipu3: Rename IspStatsRegion to Accumulator

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Mon Sep 27 20:34:06 CEST 2021


JM,

You may also want this fixup as the max cells in width is 80 ;-).

---
 src/ipa/ipu3/algorithms/awb.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
index 06570b60..67cf3a55 100644
--- a/src/ipa/ipu3/algorithms/awb.cpp
+++ b/src/ipa/ipu3/algorithms/awb.cpp
@@ -26,8 +26,8 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;
  * - Cells are defined in Pixels
  * - Zones are defined in Cells
  *
- *                     81 cells
- *     /───────────── 1296 pixels ───────────\
+ *                     80 cells
+ *     /───────────── 1280 pixels ───────────\
  *                      16 zones
  *      16
  *    ┌────┬────┬────┬────┬────┬─  ──────┬────┐   \
@@ -55,7 +55,7 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;
  *    └────┴────┴────┴────┴────┴─  ──────┴────┘   /
  *
  * The algorithm works with a fixed number of zones \a kAwbStatsSizeX x
- * \a kAwbStatsSizeY. For example, a frame of 1296x720 is divided into 81x45
+ * \a kAwbStatsSizeY. For example, a frame of 1280x720 is divided into 80x45
  * cells of [16x16] pixels. In the case of \a kAwbStatsSizeX=16 and
  * \a kAwbStatsSizeY=12 the zones are made of [5x4] cells. The cells are
  * left-aligned and calculated by IPAIPU3::calculateBdsGrid().
-- 
2.30.2



More information about the libcamera-devel mailing list