[libcamera-devel] [PATCH v1] gstreamer: Fix spelling of the work manager used in a util function

[Laurent Pinchart]

On Mon, Sep 27, 2021 at 09:27:20AM -0400, Nicolas Dufresne wrote:
> Le vendredi 24 septembre 2021 à 15:27 +0530, Vedant Paranjape a écrit :
> > Fix all name in all instances of the function gst_libcamera_get_camera_mananger
> > to gst_libcamera_get_camera_manager. Spelling of manager was incorrect.
> > 
> > This patch has no functional changes.
> > 
> > Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> 
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>

And

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > ---
> >  src/gstreamer/gstlibcamera-utils.cpp   | 2 +-
> >  src/gstreamer/gstlibcamera-utils.h     | 2 +-
> >  src/gstreamer/gstlibcameraprovider.cpp | 2 +-
> >  src/gstreamer/gstlibcamerasrc.cpp      | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp
> > index cef5b03fe204..3f2422863c03 100644
> > --- a/src/gstreamer/gstlibcamera-utils.cpp
> > +++ b/src/gstreamer/gstlibcamera-utils.cpp
> > @@ -239,7 +239,7 @@ G_LOCK_DEFINE_STATIC(cm_singleton_lock);
> >  static std::weak_ptr<CameraManager> cm_singleton_ptr;
> >  
> >  std::shared_ptr<CameraManager>
> > -gst_libcamera_get_camera_mananger(int &ret)
> > +gst_libcamera_get_camera_manager(int &ret)
> >  {
> >  	std::shared_ptr<CameraManager> cm;
> >  
> > diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h
> > index 67a06db3d28a..7087fef0a94d 100644
> > --- a/src/gstreamer/gstlibcamera-utils.h
> > +++ b/src/gstreamer/gstlibcamera-utils.h
> > @@ -20,7 +20,7 @@ GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfi
> >  void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,
> >  					      GstCaps *caps);
> >  void gst_libcamera_resume_task(GstTask *task);
> > -std::shared_ptr<libcamera::CameraManager> gst_libcamera_get_camera_mananger(int &ret);
> > +std::shared_ptr<libcamera::CameraManager> gst_libcamera_get_camera_manager(int &ret);
> >  
> >  /**
> >   * \class GLibLocker
> > diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp
> > index 948ba0d14037..aee6f9a2be2b 100644
> > --- a/src/gstreamer/gstlibcameraprovider.cpp
> > +++ b/src/gstreamer/gstlibcameraprovider.cpp
> > @@ -180,7 +180,7 @@ gst_libcamera_provider_probe(GstDeviceProvider *provider)
> >  	 * gains monitoring support. Meanwhile we need to cycle start()/stop()
> >  	 * to ensure every probe() calls return the latest list.
> >  	 */
> > -	cm = gst_libcamera_get_camera_mananger(ret);
> > +	cm = gst_libcamera_get_camera_manager(ret);
> >  	if (ret) {
> >  		GST_ERROR_OBJECT(self, "Failed to retrieve device list: %s",
> >  				 g_strerror(-ret));
> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> > index 15409106eac2..b545de4c4262 100644
> > --- a/src/gstreamer/gstlibcamerasrc.cpp
> > +++ b/src/gstreamer/gstlibcamerasrc.cpp
> > @@ -204,7 +204,7 @@ gst_libcamera_src_open(GstLibcameraSrc *self)
> >  
> >  	GST_DEBUG_OBJECT(self, "Opening camera device ...");
> >  
> > -	cm = gst_libcamera_get_camera_mananger(ret);
> > +	cm = gst_libcamera_get_camera_manager(ret);
> >  	if (ret) {
> >  		GST_ELEMENT_ERROR(self, LIBRARY, INIT,
> >  				  ("Failed listing cameras."),

-- 
Regards,

Laurent Pinchart