[libcamera-devel] [IPU3-IPA PATCH] ipu3: Use new sensor controls

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Tue Sep 28 12:32:39 CEST 2021


Hi Kieran,

On 28/09/2021 12:10, Kieran Bingham wrote:
> The IPU3 interface was updated in 4c1fc33d8ab9 ("libcamera: ipu3: Drop
> entityControls map") where the sensor controls are given their own
> dedicated control list and is named accordingly.
> 
> Update the IPU3 IPA to match the new interface update.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

> ---
>  ipu3.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ipu3.cpp b/ipu3.cpp
> index 3e89e6dd4e02..b60c58c990af 100644
> --- a/ipu3.cpp
> +++ b/ipu3.cpp
> @@ -201,14 +201,14 @@ int IPAIPU3::start()
>  
>  int IPAIPU3::configure(const IPAConfigInfo &configInfo)
>  {
> -	if (configInfo.entityControls.empty()) {
> -		LOG(IPAIPU3, Error) << "No controls provided";
> +	if (configInfo.sensorControls.empty()) {
> +		LOG(IPAIPU3, Error) << "No sensor controls provided";
>  		return -ENODATA;
>  	}
>  
>  	sensorInfo_ = configInfo.sensorInfo;
>  
> -	ctrls_ = configInfo.entityControls.at(0);
> +	ctrls_ = configInfo.sensorControls;
>  
>  	const auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);
>  	if (itExp == ctrls_.end()) {
> 


More information about the libcamera-devel mailing list