[libcamera-devel] [PATCH 04/18] ipa: ipu3: Explicitly use the statistics parameter

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Thu Sep 30 11:54:59 CEST 2021


The stats pointer is marked as [[maybe_unused]]. This is a leftover from
a previous commit which was here to keep the compatibility while
transitioning to the new iterative algorithms.

Remove this attribute to make it explicit that stats are really used to
feed the algorithms.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/ipa/ipu3/ipu3.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index 147b40ab..a27f5e98 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -625,7 +625,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)
  */
 void IPAIPU3::parseStatistics(unsigned int frame,
 			      [[maybe_unused]] int64_t frameTimestamp,
-			      [[maybe_unused]] const ipu3_uapi_stats_3a *stats)
+			      const ipu3_uapi_stats_3a *stats)
 {
 	ControlList ctrls(controls::controls);
 
-- 
2.30.2



More information about the libcamera-devel mailing list