[libcamera-devel] [PATCH 14/18] ipa: ipu3: ipa_context: Fix doxygen references

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Thu Sep 30 11:55:09 CEST 2021


From: Kieran Bingham <kieran.bingham at ideasonboard.com>

The IPAFrameContext use unamed structures to group items.
Doxygen can not reference the member variables of the container structures
through the variable names, and expects the structure type name. As this is not
given, the structure variables are referenced from the parent structure.

Remove the member name from the annonymous type to allow Doxygen to
match the implementation from the documentation.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/ipa/ipu3/ipa_context.cpp | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp
index 40d79772..a38e6053 100644
--- a/src/ipa/ipu3/ipa_context.cpp
+++ b/src/ipa/ipu3/ipa_context.cpp
@@ -59,10 +59,10 @@ namespace libcamera::ipa::ipu3 {
  * \struct IPASessionConfiguration::grid
  * \brief Grid configuration of the IPA
  *
- * \var IPASessionConfiguration::grid::bdsGrid
+ * \var IPASessionConfiguration::bdsGrid
  * \brief Bayer Down Scaler grid plane config used by the kernel
  *
- * \var IPASessionConfiguration::grid::bdsOutputSize
+ * \var IPASessionConfiguration::bdsOutputSize
  * \brief BDS output size configured by the pipeline handler
  */
 
@@ -73,10 +73,10 @@ namespace libcamera::ipa::ipu3 {
  * The exposure and gain determined are expected to be applied to the sensor
  * at the earliest opportunity.
  *
- * \var IPAFrameContext::agc::exposure
+ * \var IPAFrameContext::exposure
  * \brief Exposure time expressed as a number of lines
  *
- * \var IPAFrameContext::agc::gain
+ * \var IPAFrameContext::gain
  * \brief Analogue gain multiplier
  *
  * The gain should be adapted to the sensor specific gain code before applying.
@@ -89,13 +89,13 @@ namespace libcamera::ipa::ipu3 {
  * \struct IPAFrameContext::awb::gains
  * \brief White balance gains
  *
- * \var IPAFrameContext::awb::gains::red
+ * \var IPAFrameContext::red
  * \brief White balance gain for R channel
  *
- * \var IPAFrameContext::awb::gains::green
+ * \var IPAFrameContext::green
  * \brief White balance gain for G channel
  *
- * \var IPAFrameContext::awb::gains::blue
+ * \var IPAFrameContext::blue
  * \brief White balance gain for B channel
  */
 
@@ -103,7 +103,10 @@ namespace libcamera::ipa::ipu3 {
  * \struct IPAFrameContext::toneMapping
  * \brief Context for ToneMapping and Gamma control
  *
- * \var IPAFrameContext::toneMapping::gammaCorrection
+ * \var IPAFrameContext::gamma
+ * \brief Gamma value for the LUT
+ *
+ * \var IPAFrameContext::gammaCorrection
  * \brief Per-pixel tone mapping implemented as a LUT
  *
  * The LUT structure is defined by the IPU3 kernel interface. See
-- 
2.30.2



More information about the libcamera-devel mailing list