[libcamera-devel] [PATCH 2/2] ipa: vimc: Rename processControls() to queueRequest()

[paul.elder at ideasonboard.com]

Hi Umang,

On Thu, Mar 31, 2022 at 10:27:25PM +0530, Umang Jain via libcamera-devel wrote:
> Synchronise with other IPA intefaces (for e.g. IPU3, RkISP1)
> that uses queueRequest() to pass in the request controls to
> IPA.
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  include/libcamera/ipa/vimc.mojom     | 2 +-
>  src/ipa/vimc/vimc.cpp                | 6 +++---
>  src/libcamera/pipeline/vimc/vimc.cpp | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom
> index e3b14e38..e5ac3609 100644
> --- a/include/libcamera/ipa/vimc.mojom
> +++ b/include/libcamera/ipa/vimc.mojom
> @@ -37,7 +37,7 @@ interface IPAVimcInterface {
>  	 * handle parameters at runtime.
>  	 */
>  	[async] fillParams(uint32 frame, uint32 bufferId);
> -	[async] processControls(uint32 frame, libcamera.ControlList controls);
> +	[async] queueRequest(uint32 frame, libcamera.ControlList controls);
>  };
>  
>  interface IPAVimcEventInterface {
> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
> index 8481b82b..315302c6 100644
> --- a/src/ipa/vimc/vimc.cpp
> +++ b/src/ipa/vimc/vimc.cpp
> @@ -44,7 +44,7 @@ public:
>  	void unmapBuffers(const std::vector<unsigned int> &ids) override;
>  
>  	void fillParams(uint32_t frame, uint32_t bufferId) override;
> -	void processControls(uint32_t frame, const ControlList &controls) override;
> +	void queueRequest(uint32_t frame, const ControlList &controls) override;
>  
>  private:
>  	void initTrace();
> @@ -140,8 +140,8 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)
>  	paramsFilled.emit(bufferId);
>  }
>  
> -void IPAVimc::processControls([[maybe_unused]] uint32_t frame,
> -			      [[maybe_unused]] const ControlList &controls)
> +void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,
> +			   [[maybe_unused]] const ControlList &controls)
>  {
>  }
>  
> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
> index 29960fe3..69b83d07 100644
> --- a/src/libcamera/pipeline/vimc/vimc.cpp
> +++ b/src/libcamera/pipeline/vimc/vimc.cpp
> @@ -432,7 +432,7 @@ int PipelineHandlerVimc::queueRequestDevice(Camera *camera, Request *request)
>  	if (ret < 0)
>  		return ret;
>  
> -	data->ipa_->processControls(request->sequence(), request->controls());
> +	data->ipa_->queueRequest(request->sequence(), request->controls());
>  
>  	return 0;
>  }
> -- 
> 2.31.0
>