[libcamera-devel] [PATCH v3 2/2] libcamera: correct the string representation of Rectangle
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue Apr 19 15:53:42 CEST 2022
Quoting Laurent Pinchart via libcamera-devel (2022-04-19 14:12:56)
> On Tue, Apr 19, 2022 at 04:10:49PM +0300, Laurent Pinchart via libcamera-devel wrote:
> > Hi Han-Lin,
> >
> > On Tue, Apr 19, 2022 at 08:42:20PM +0800, Han-Lin Chen via libcamera-devel wrote:
> > > Change the string representation of class Rectangle from
> > > "(top x left)/width x height" to "(top, left)/width x height".
> >
> > Good catch !
> >
> > > Signed-off-by: Han-Lin Chen <hanlinchen at chromium.org>
> > > ---
> > > src/libcamera/geometry.cpp | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp
> > > index da08045e..e00333cf 100644
> > > --- a/src/libcamera/geometry.cpp
> > > +++ b/src/libcamera/geometry.cpp
> > > @@ -841,7 +841,7 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs)
> > > */
> > > std::ostream &operator<<(std::ostream &out, const Rectangle &r)
> > > {
> > > - out << "(" << r.x << "x" << r.y << ")/" << r.width << "x" << r.height;
> > > + out << "(" << r.x << ", " << r.y << ")/" << r.width << "x" << r.height;
> >
> > I'd remove the space after the comma. With that,
>
> Actually the Point class has the same issue. Let's keep it as-is here
> and fix both on top.
>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> >
> > I can fix when applying.
> >
> > > return out;
> > > }
> > >
>
> --
> Regards,
>
> Laurent Pinchart
More information about the libcamera-devel
mailing list