[libcamera-devel] [PATCH v3 0/2] Introduce YamlParser YAML files
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Apr 20 10:12:24 CEST 2022
Hi Han-Lin,
On Mon, Apr 18, 2022 at 08:09:21PM +0800, Han-Lin Chen via libcamera-devel wrote:
> Hi,
> The series is a subset of the previous series for configuration files,
> which moves the YamlParser related patches as the separate series.
>
> Many thanks for previous comments.
>
> Comparing to V2:
> 1. Correct the error handling for strtol, strtod and strtoul.
>
> Han-Lin Chen (2):
> libcamera: Introduce YamlParser as a helper to parse yaml files
> android: camera_hal_config: Use YamlParser to parse android HAL config
Something I forgot to mention, a unit test would be good :-) Code
without unit tests is bound to get broken quickly.
> README.rst | 4 +-
> include/libcamera/internal/meson.build | 1 +
> include/libcamera/internal/yaml_parser.h | 86 +++
> src/android/camera_hal_config.cpp | 334 +++-------
> src/android/meson.build | 1 -
> src/libcamera/meson.build | 3 +
> src/libcamera/yaml_parser.cpp | 802 +++++++++++++++++++++++
> 7 files changed, 968 insertions(+), 263 deletions(-)
> create mode 100644 include/libcamera/internal/yaml_parser.h
> create mode 100644 src/libcamera/yaml_parser.cpp
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list