[libcamera-devel] [PATCH v3 0/1] AF controls

[Jacopo Mondi]

Hi David,

On Wed, Apr 20, 2022 at 05:26:21PM +0100, David Plowman wrote:
> Hi everyone
>
> Changes in v3:
>
> * The controls have all been "un-draft-ified". I've moved them all up
>   the file to the non-draft section.
>
> * We had a discussion about having a "custom" range, but I think the
>   conclusion for the moment was not to add it. Please correct me if
>   I'm wrong there.

I think it's fine for now. we can add it on top and leave it out to
reduce the discussions and fast track this version.

>
> * The AfLensPosition control has gone. Instead LensPosition is defined
>   to use a scaled "dioptre-like" kind of unit (hyperfocal distance
>   divided by focal distance), so that 0 = infinity, 1 = hyperfocal,
>   bigger numbers = closer.
>
> * The AfState has been reduced to just
>   reset/scanning/focused/failed. It is expected that AfMode will be
>   reported on every frame, and also the new AfPauseState which says
>   whether CAF is running/pausing/paused.
>
> * I note that there's still some discussion elsewhere about the units
>   for defining AF regions, and whether they need to have associated
>   weights.
>
> * I haven't carried any tags over for now, I think things are still at
>   a stage where everyone needs to review the changes, if that's OK!
>
> The state transition diagram is cosmetically updated, but not
> materially different. It should be in the same place, but in case
> you've lost the link:
> https://docs.google.com/drawings/d/1rU2nS82dEC8Y2eY0lKPkQQhd67gKLOl7PvSeUcL1j_E/edit?usp=sharing
>
> Thanks!
> David
>
> David Plowman (1):
>   libcamera: controls: Controls for driving AF (autofocus) algorithms
>
>  src/libcamera/control_ids.yaml | 318 ++++++++++++++++++++++++++-------
>  1 file changed, 258 insertions(+), 60 deletions(-)
>
> --
> 2.30.2
>