[libcamera-devel] [PATCH v2 1/4] Allow inheritance of FrameBuffer

Harvey Yang chenghaoyang at chromium.org
Tue Apr 26 11:00:26 CEST 2022


To add buffer_handle_t access in android, this CL allows inheritance of
FrameBuffer to add a derived class in android.
---
 include/libcamera/framebuffer.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h
index 3b1118d1..e6c769b4 100644
--- a/include/libcamera/framebuffer.h
+++ b/include/libcamera/framebuffer.h
@@ -46,7 +46,7 @@ private:
 	std::vector<Plane> planes_;
 };
 
-class FrameBuffer final : public Extensible
+class FrameBuffer : public Extensible
 {
 	LIBCAMERA_DECLARE_PRIVATE()
 
@@ -61,6 +61,7 @@ public:
 	FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);
 	FrameBuffer(std::unique_ptr<Private> d,
 		    const std::vector<Plane> &planes, unsigned int cookie = 0);
+	virtual ~FrameBuffer() {}
 
 	const std::vector<Plane> &planes() const { return planes_; }
 	Request *request() const;
-- 
2.36.0.rc2.479.g8af0fa9b8e-goog



More information about the libcamera-devel mailing list