[libcamera-devel] [PATCH v3 1/4] Allow inheritance of FrameBuffer

[Laurent Pinchart]

Hi Harvey,

Thank you for the patch.

On Tue, Apr 26, 2022 at 09:14:06AM +0000, Harvey Yang via libcamera-devel wrote:
> To add buffer_handle_t access in android, this CL allows inheritance of

We use the term "patch" or "change", not "CL". Apart from that, the
patch looks good, assuming review of the subsequent patches don't reveal
issues that affect this one.

On a side note, if we allow inheriting from the FrameBuffer class, I
wonder if we should drop the cookie() and setCookie() functions. Users
of the class that need to associate private data with it can always
inherit to extend FrameBuffer. That's a candidate for a separate change
of course, but what does everybody think ?

> FrameBuffer to add a derived class in android.
> 
> Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
> ---
>  include/libcamera/framebuffer.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h
> index 3b1118d1..e6c769b4 100644
> --- a/include/libcamera/framebuffer.h
> +++ b/include/libcamera/framebuffer.h
> @@ -46,7 +46,7 @@ private:
>  	std::vector<Plane> planes_;
>  };
>  
> -class FrameBuffer final : public Extensible
> +class FrameBuffer : public Extensible
>  {
>  	LIBCAMERA_DECLARE_PRIVATE()
>  
> @@ -61,6 +61,7 @@ public:
>  	FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);
>  	FrameBuffer(std::unique_ptr<Private> d,
>  		    const std::vector<Plane> &planes, unsigned int cookie = 0);
> +	virtual ~FrameBuffer() {}
>  
>  	const std::vector<Plane> &planes() const { return planes_; }
>  	Request *request() const;

-- 
Regards,

Laurent Pinchart