[libcamera-devel] [PATCH 13/13] libcamera: pipeline: simple: Add support for NXP ISI

[Laurent Pinchart]

Hi Jacopo,

On Mon, Aug 01, 2022 at 06:26:31PM +0200, Jacopo Mondi wrote:
> On Mon, Aug 01, 2022 at 03:05:43AM +0300, Laurent Pinchart via libcamera-devel wrote:
> > Several NXP i.MX8 SoCs (such as the i.MX8MN and i.MX8MP) contain a
> > camera pipeline made of sensor interfaces (with parallel and/or CSI-2
> > receivers) and an image processing engine named ISI. The ISI contains an
> > input crossbar switch and one or more processing pipelines capable of
> > format conversion and scaling.
> >
> > This is a good candidate for the simple pipeline handler as a first
> > step. The i.MX8MP should eventually graduate to having its own pipeline
> > handler as it also contains two ISP instances.
> 
> Or this can already be updated to mention rkisp1 ?

I'll add "... two ISP instances (supported by the rkisp1 driver).".

> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> 
> > ---
> >  src/libcamera/pipeline/simple/simple.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> > index c80e462bc449..d7b1c9de93b5 100644
> > --- a/src/libcamera/pipeline/simple/simple.cpp
> > +++ b/src/libcamera/pipeline/simple/simple.cpp
> > @@ -191,6 +191,7 @@ namespace {
> >
> >  static const SimplePipelineInfo supportedDevices[] = {
> >  	{ "imx7-csi", { { "pxp", 1 } } },
> > +	{ "mxc-isi", {} },
> >  	{ "qcom-camss", {} },
> >  	{ "sun6i-csi", {} },
> >  };

-- 
Regards,

Laurent Pinchart