[libcamera-devel] [PATCH] ipa: raspberrypi: Reset embedded data parser on configure

[Naushir Patuck]

Hi David,


On Tue, 2 Aug 2022 at 09:45, David Plowman via libcamera-devel <
libcamera-devel at lists.libcamera.org> wrote:

> When we switch camera mode following a pipeline reconfiguration, the
> embedded data parser should be "reset" to discard any data that it may
> have cached and that might now be invalid.
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
>

Reviewed-by: Naushir Patuck <naush at raspberrypi.com>


> ---
>  src/ipa/raspberrypi/cam_helper.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/ipa/raspberrypi/cam_helper.cpp
> b/src/ipa/raspberrypi/cam_helper.cpp
> index 37b66198..cac8f39e 100644
> --- a/src/ipa/raspberrypi/cam_helper.cpp
> +++ b/src/ipa/raspberrypi/cam_helper.cpp
> @@ -106,6 +106,7 @@ void CamHelper::setCameraMode(const CameraMode &mode)
>  {
>         mode_ = mode;
>         if (parser_) {
> +               parser_->reset();
>                 parser_->setBitsPerPixel(mode.bitdepth);
>                 parser_->setLineLengthBytes(0); /* We use SetBufferSize. */
>         }
> --
> 2.30.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20220802/989142ed/attachment.htm>