[libcamera-devel] [PATCH 5/9] libcamera: ipa_interface: Include flags.h

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Aug 9 03:45:58 CEST 2022


Hi Paul,

Thank you for the patch.

On Wed, Aug 03, 2022 at 08:21:46PM +0900, Paul Elder via libcamera-devel wrote:
> Since we will soon be adding support for Flags in IPA interfaces, the
> header for Flags needs to be included in ipa_interface.h. Do so.

While I'm all for the "one change, one patch" philosophy, we're reaching
the limits of what's reasonable :-) Please squash this with the patch
that uses it.

> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  include/libcamera/ipa/ipa_interface.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
> index 50ca0e7b..8afcfe21 100644
> --- a/include/libcamera/ipa/ipa_interface.h
> +++ b/include/libcamera/ipa/ipa_interface.h
> @@ -13,6 +13,7 @@
>  #include <map>
>  #include <vector>
>  
> +#include <libcamera/base/flags.h>
>  #include <libcamera/base/signal.h>
>  
>  #include <libcamera/controls.h>

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list