[libcamera-devel] [PATCH 1/3] libcamera: remove unused header

[Laurent Pinchart]

Hi Christian,

Thank you for the patch.

On Sun, Aug 14, 2022 at 11:52:39AM +0200, Christian Rauch via libcamera-devel wrote:


A commit message is needed, with a body and a Signed-off-by line. Same
for the other patches in the series.

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp             | 1 -
>  test/serialization/ipa_data_serializer_test.cpp | 4 ----
>  2 files changed, 5 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 69c73f8c..8d731435 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -49,7 +49,6 @@
>  #include "geq_status.h"
>  #include "lux_status.h"
>  #include "metadata.h"
> -#include "noise_status.h"

Out of curiosity, how did you figure out this was not needed ?

>  #include "sharpen_algorithm.h"
>  #include "sharpen_status.h"
> 
> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
> index d2050a86..377ecdb0 100644
> --- a/test/serialization/ipa_data_serializer_test.cpp
> +++ b/test/serialization/ipa_data_serializer_test.cpp
> @@ -20,11 +20,7 @@
>  #include <libcamera/base/thread.h>
>  #include <libcamera/base/timer.h>
> 
> -#include "libcamera/internal/device_enumerator.h"
>  #include "libcamera/internal/ipa_data_serializer.h"
> -#include "libcamera/internal/ipa_manager.h"
> -#include "libcamera/internal/ipa_module.h"
> -#include "libcamera/internal/pipeline_handler.h"
> 
>  #include "serialization_test.h"
>  #include "test.h"

-- 
Regards,

Laurent Pinchart