[libcamera-devel] [PATCH 3/3] libcamera: pipeline: remove unused assignment

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Aug 16 05:50:43 CEST 2022


Hi Christian,

Thank you for the patch.

On Sun, Aug 14, 2022 at 11:52:41AM +0200, Christian Rauch via libcamera-devel wrote:

With a commit message,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> Signed-off-by: Christian Rauch <Rauch.Christian at gmx.de>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 93287332..03bbe6b4 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
>  		/* \todo Turn this into a hard failure. */
>  		LOG(RkISP1, Warning) << "Camera sensor information not available";
>  		sensorInfo = {};
> -		ret = 0;
>  	}
> 
>  	std::map<uint32_t, ControlInfoMap> entityControls;

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list