[libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: remove unused assignment
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Aug 16 21:27:12 CEST 2022
Hi Christian,
Thank you for the patch.
On Tue, Aug 16, 2022 at 08:38:26PM +0200, Christian Rauch via libcamera-devel wrote:
> The variable 'ret' is assigned but not read until after the next assignment.
>
> Signed-off-by: Christian Rauch <Rauch.Christian at gmx.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 93287332..03bbe6b4 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
> /* \todo Turn this into a hard failure. */
> LOG(RkISP1, Warning) << "Camera sensor information not available";
> sensorInfo = {};
> - ret = 0;
> }
>
> std::map<uint32_t, ControlInfoMap> entityControls;
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list