[libcamera-devel] [PATCH v3 06/17] py: Use UniqueFD

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Thu Aug 18 16:43:46 CEST 2022


On 18/08/2022 17:23, Jacopo Mondi wrote:
> Hi Tomi
> 
> On Fri, Jul 01, 2022 at 11:45:10AM +0300, Tomi Valkeinen wrote:
>> Use UniqueFD to automate the eventfd lifetime management.
>>
> 
> Here you go :)
> 
> Can you squash with the previous patch  ?

No, I don't think it's a good idea to squash changes like this. The 
point of the previous patch was to convert the existing code to 
PyCameraManager. I don't do any changes there that are not needed.

Squashing this, EFD_CLOEXEC and the mutex change would hide these 
changes inside the large refactoring done in the previous patch.

  Tomi


More information about the libcamera-devel mailing list