[libcamera-devel] [PATCH v3 14/17] py: simple-capture.py: Use new events support

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Fri, Jul 01, 2022 at 11:45:18AM +0300, Tomi Valkeinen wrote:

A commit message would be nice here too.

> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
> ---
>  src/py/examples/simple-capture.py | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/src/py/examples/simple-capture.py b/src/py/examples/simple-capture.py
> index 4b85408f..c26e638b 100755
> --- a/src/py/examples/simple-capture.py
> +++ b/src/py/examples/simple-capture.py
> @@ -107,7 +107,7 @@ def main():
>      sel.register(cm.event_fd, selectors.EVENT_READ)
>  
>      while frames_done < TOTAL_FRAMES:
> -        # cm.get_ready_requests() does not block, so we use a Selector to wait
> +        # cm.get_events() does not block, so we use a Selector to wait
>          # for a camera event. Here we should almost always get a single
>          # Request, but in some cases there could be multiple or none.

"Here we should almost always get a single request completion event, but
in some cases there could be multiple ones, other events, or no events
at all."

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  
> @@ -115,9 +115,13 @@ def main():
>          if not events:
>              continue
>  
> -        reqs = cm.get_ready_requests()
> +        for ev in cm.get_events():
> +            # We are only interested in RequestCompleted events
> +            if ev.type != libcam.Event.Type.RequestCompleted:
> +                continue
> +
> +            req = ev.request
>  
> -        for req in reqs:
>              frames_done += 1
>  
>              buffers = req.buffers

-- 
Regards,

Laurent Pinchart