[libcamera-devel] [PATCH v2 0/6] AEGC controls

[Laurent Pinchart]

Hi Jacopo,

On Thu, Aug 11, 2022 at 05:02:13PM +0200, Jacopo Mondi via libcamera-devel wrote:
> Hello
>   this series collects patch 1/3 from Paul's
> https://patchwork.libcamera.org/project/libcamera/list/?series=3123
> 
> with fixups proposed in-reply to that series applied on top.

Thanks for this consolidated version. I'm however a bit worried that
leaving patches 2/3 and 3/3 from Paul's series out will mean we'll
forget about them forever. Is there anything that blocks their inclusion
in this series ?

> The rest of the series ports the existing users in the code base to the
> new controls.
> 
> Particularly relevant is the RPi conversion (with Naush and David in Cc)
> as it's the only pipeline that actually handles the AEGC controls.
> The RPi changes have been compiled-tested only, hence they certainly
> require more attention, but that's a start to check if the direction is
> the desired one.
> 
> Thanks
>    j
> 
> Jacopo Mondi (5):
>   libcamera: uvcvideo: Register ExposureTimeMode control
>   test: ipa_data_serialization: Use ExposureTimeMode
>   ipa: raspberry: Port to the new AEGC controls
>   ipa: rkisp1: Remove AE-related controls
>   controls: Remove AeEnable and AeLocked
> 
> Paul Elder (1):
>   controls: Introduce AEGC-related controls
> 
>  .../raspberrypi/controller/agc_algorithm.h    |   6 +
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    |  24 +-
>  src/ipa/raspberrypi/controller/rpi/agc.h      |   8 +-
>  src/ipa/raspberrypi/raspberrypi.cpp           |  76 ++++-
>  src/ipa/rkisp1/rkisp1.cpp                     |  19 +-
>  src/libcamera/control_ids.yaml                | 279 ++++++++++++++----
>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  54 +++-
>  .../ipa_data_serializer_test.cpp              |   2 +-
>  8 files changed, 370 insertions(+), 98 deletions(-)

-- 
Regards,

Laurent Pinchart