[libcamera-devel] [PATCH v4 1/6] py: meson: Use libcamera_private dependency

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Fri Aug 19 13:16:10 CEST 2022


We define -DLIBCAMERA_BASE_PRIVATE to get access to libcamera private
headers, but the correct way to do this is to have a meson dependency to
libcamera_private.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
---
 src/py/libcamera/meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
index 04578bac..99c2a8c0 100644
--- a/src/py/libcamera/meson.build
+++ b/src/py/libcamera/meson.build
@@ -60,7 +60,7 @@ pycamera_sources += custom_target('py_gen_formats',
                                   command : [gen_py_formats, '-o', '@OUTPUT@', '@INPUT@'])
 
 pycamera_deps = [
-    libcamera_public,
+    libcamera_private,
     py3_dep,
     pybind11_dep,
 ]
@@ -69,7 +69,6 @@ pycamera_args = [
     '-fvisibility=hidden',
     '-Wno-shadow',
     '-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT',
-    '-DLIBCAMERA_BASE_PRIVATE',
 ]
 
 destdir = get_option('libdir') / ('python' + py3_dep.version()) / 'site-packages' / 'libcamera'
-- 
2.34.1



More information about the libcamera-devel mailing list