[libcamera-devel] [PATCH v4 4/6] py: Set EFD_CLOEXEC on eventfd to avoid fd leaking

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Fri Aug 19 13:16:13 CEST 2022


Set EFD_CLOEXEC on eventfd to avoid fd leaking.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/py/libcamera/py_camera_manager.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/py/libcamera/py_camera_manager.cpp b/src/py/libcamera/py_camera_manager.cpp
index 18fdb623..8bfb8e57 100644
--- a/src/py/libcamera/py_camera_manager.cpp
+++ b/src/py/libcamera/py_camera_manager.cpp
@@ -24,7 +24,7 @@ PyCameraManager::PyCameraManager()
 
 	cameraManager_ = std::make_unique<CameraManager>();
 
-	int fd = eventfd(0, 0);
+	int fd = eventfd(0, EFD_CLOEXEC);
 	if (fd == -1)
 		throw std::system_error(errno, std::generic_category(),
 					"Failed to create eventfd");
-- 
2.34.1



More information about the libcamera-devel mailing list