[libcamera-devel] [PATCH v7 0/6] Add CrOS JEA implementation

[Cheng-Hao Yang]

Hi Kieran,

I see, while I actually found that the patch leads to a flaky crash in cros
camera service. I'm still debugging with Han-lin. After I find the root
cause,
I'll ask Tomasz to take a look. And I'll also provide the CTS result.

On Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham <
kieran.bingham at ideasonboard.com> wrote:

> Hi Harvey,
>
> Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)
> > Rebased and fixed some merge conflicts on the master branch.
> > Please check if it's ready to merge.
> > Thanks!
>
> One of our usual key requirements for merge are at least two reviewers
> having reviewed and provided reviewed-by tags (after working through any
> identified issues and discussions).
>
> As this component is greatly affecting the Android layer which is used
> extensively by ChromeOS ... could we have one of the required reviewers
> and testers being from Google or Chromium teams please?
>
> Providing a reference to results from running CTS would also be
> beneficial here.
>
> --
> Kieran
>
>
> > BR,
> > Harvey
> >
> >
> > Harvey Yang (6):
> >   Allow inheritance of FrameBuffer
> >   Add HALFrameBuffer and replace FrameBuffer in src/android
> >   Add meson.build in src/android/jpeg
> >   Move generateThumbnail from PostProcessorJpeg to Encoder
> >   Pass StreamBuffer to Encoder::encoder
> >   Add JEA implementation
> >
> >  include/libcamera/framebuffer.h               |   3 +-
> >  src/android/camera_device.cpp                 |   3 +-
> >  src/android/cros/camera3_hal.cpp              |   2 +
> >  src/android/cros_mojo_token.h                 |  12 ++
> >  src/android/frame_buffer_allocator.h          |   7 +-
> >  src/android/hal_framebuffer.cpp               |  22 +++
> >  src/android/hal_framebuffer.h                 |  26 ++++
> >  src/android/jpeg/encoder.h                    |  10 +-
> >  src/android/jpeg/encoder_jea.cpp              |  93 ++++++++++++
> >  src/android/jpeg/encoder_jea.h                |  35 +++++
> >  src/android/jpeg/encoder_libjpeg.cpp          | 133 ++++++++++++++----
> >  src/android/jpeg/encoder_libjpeg.h            |  33 ++++-
> >  src/android/jpeg/meson.build                  |  16 +++
> >  src/android/jpeg/post_processor_jpeg.cpp      |  65 ++-------
> >  src/android/jpeg/post_processor_jpeg.h        |  11 +-
> >  src/android/meson.build                       |   6 +-
> >  .../mm/cros_frame_buffer_allocator.cpp        |   9 +-
> >  .../mm/generic_frame_buffer_allocator.cpp     |  11 +-
> >  18 files changed, 385 insertions(+), 112 deletions(-)
> >  create mode 100644 src/android/cros_mojo_token.h
> >  create mode 100644 src/android/hal_framebuffer.cpp
> >  create mode 100644 src/android/hal_framebuffer.h
> >  create mode 100644 src/android/jpeg/encoder_jea.cpp
> >  create mode 100644 src/android/jpeg/encoder_jea.h
> >  create mode 100644 src/android/jpeg/meson.build
> >
> > --
> > 2.38.1.584.g0f3c55d4c2-goog
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20221207/2271a00a/attachment.htm>