[libcamera-devel] [PATCH] Simple typo fixes
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sat Dec 10 22:04:16 CET 2022
Hi Pavel,
Thank you for the patch.
On Sat, Dec 10, 2022 at 09:58:53PM +0100, Pavel Machek via libcamera-devel wrote:
> During reading the code, I found some typos that could be fixed.
>
> Signed-off-by: Pavel Machek <pavel at ucw.cz>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
It would be nice to integrate a spellchecker into our checkstyle.py
script. Last time I have a look at it (that was a while ago) it wasn't
exactly trivial, even if we could extra comments properly (requiring C++
parsing), there would likely be lots of false positives.
> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
> index 9256bbba..d5fabaf1 100644
> --- a/src/ipa/vimc/vimc.cpp
> +++ b/src/ipa/vimc/vimc.cpp
> @@ -2,7 +2,7 @@
> /*
> * Copyright (C) 2019, Google Inc.
> *
> - * ipa_vimc.cpp - Vimc Image Processing Algorithm module
> + * vimc.cpp - Vimc Image Processing Algorithm module
> */
> #include <libcamera/ipa/vimc_ipa_interface.h>
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 231b16ec..d0a2d2c5 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -214,7 +214,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req
> FrameBuffer *paramBuffer = pipe_->availableParamBuffers_.front();
>
> if (pipe_->availableStatBuffers_.empty()) {
> - LOG(RkISP1, Error) << "Statisitc buffer underrun";
> + LOG(RkISP1, Error) << "Statistic buffer underrun";
> return nullptr;
> }
> FrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();
> @@ -331,7 +331,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)
>
> /*
> * The API tuning file is made from the sensor name unless the
> - * environment variable overrides it. If
> + * environment variable overrides it.
> */
> std::string ipaTuningFile;
> char const *configFromEnv = utils::secure_getenv("LIBCAMERA_RKISP1_TUNING_FILE");
> @@ -507,7 +507,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()
> }
> }
>
> - /* All paths rejected configuraiton. */
> + /* All paths rejected configuration. */
> LOG(RkISP1, Debug) << "Camera configuration not supported "
> << cfg.toString();
> return Invalid;
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list